RFC: rust: chrdev: fix use-after-free on module unload#207
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that this issue is potentially present on any driver module which
stores its
cdevinkmalloc-ed memory. This is not seen as a problem,as module unloading is currently "best effort" only.
The kernel's
struct cdevis a reference-countedkobject. Thismeans that the object isn't guaranteed to be cleaned up after a
call to
cdev_del- the cleanup may occur later.Rust's
chrdevplaces thestruct cdevinkmalloc-ed memory.On module unload, it calls
cdev_delandkfrees all module memory,including the
struct cdev. But that structure might only be cleanedup later - resulting in a potential use-after-free.
This issue is reliably triggered using CONFIG_DEBUG_KOBJECT_RELEASE,
which has been developed specifically to catch this subtle class of
bugs.
Fix by allocating the
cdevusingcdev_alloc, which stores theobject on the kernel's
kallocheap. Now it can outlive themodule, and be cleaned up+released when the kernel decides it's time.